Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate API Credentials in Admin Portal #1016

Closed
wants to merge 9 commits into from

Conversation

yuanyuan-git-tech
Copy link

@yuanyuan-git-tech yuanyuan-git-tech commented Aug 1, 2023

https://2u-internal.atlassian.net/browse/ENT-7335

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 92.74% and project coverage change: +0.13% 🎉

Comparison is base (8500f4d) 83.24% compared to head (4e87955) 83.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   83.24%   83.37%   +0.13%     
==========================================
  Files         400      409       +9     
  Lines        8702     8825     +123     
  Branches     1797     1815      +18     
==========================================
+ Hits         7244     7358     +114     
- Misses       1420     1429       +9     
  Partials       38       38              
Files Changed Coverage Δ
.../components/ContactCustomerSupportButton/index.jsx 100.00% <ø> (ø)
src/data/services/LmsApiService.js 33.92% <12.50%> (-1.08%) ⬇️
src/components/settings/SettingsTabs.jsx 88.57% <80.00%> (-1.76%) ⬇️
...ettings/SettingsApiCredentialsTab/CopiedButton.jsx 92.85% <92.85%> (ø)
.../SettingsApiCredentialsTab/APICredrentialsPage.jsx 100.00% <100.00%> (ø)
...nts/settings/SettingsApiCredentialsTab/Context.jsx 100.00% <100.00%> (ø)
...settings/SettingsApiCredentialsTab/CopiedToast.jsx 100.00% <100.00%> (ø)
...settings/SettingsApiCredentialsTab/FailedAlert.jsx 100.00% <100.00%> (ø)
...ngs/SettingsApiCredentialsTab/HelpCenterButton.jsx 100.00% <100.00%> (ø)
...redentialsTab/RegenerateCredentialWarningModal.jsx 100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuanyuan-git-tech
Copy link
Author

yuanyuan-git-tech commented Aug 7, 2023

Screenshot 2023-08-07 at 9 57 12 AM
Screenshot 2023-08-12 at 11 32 09 PM

@yuanyuan-git-tech yuanyuan-git-tech requested a review from a team August 7, 2023 14:10
@yuanyuan-git-tech yuanyuan-git-tech deleted the yuanyuan/ENT-7335 branch August 14, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants