Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate API Credentials in Admin Portal #1018

Closed
wants to merge 19 commits into from

Conversation

yuanyuan-git-tech
Copy link

@yuanyuan-git-tech yuanyuan-git-tech commented Aug 14, 2023

https://2u-internal.atlassian.net/browse/ENT-7335

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@yuanyuan-git-tech
Copy link
Author

Screenshot 2023-08-07 at 9 57 12 AM
Screenshot 2023-08-12 at 11 32 09 PM

@yuanyuan-git-tech yuanyuan-git-tech requested a review from a team August 14, 2023 16:02
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 92.37% and project coverage change: +0.12% 🎉

Comparison is base (31f4dc8) 82.89% compared to head (9292c57) 83.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   82.89%   83.01%   +0.12%     
==========================================
  Files         402      412      +10     
  Lines        8735     8850     +115     
  Branches     1805     1822      +17     
==========================================
+ Hits         7241     7347     +106     
- Misses       1455     1464       +9     
  Partials       39       39              
Files Changed Coverage Δ
.../components/ContactCustomerSupportButton/index.jsx 100.00% <ø> (ø)
src/components/settings/SettingsLMSTab/index.jsx 95.45% <ø> (ø)
src/data/reducers/portalConfiguration.js 73.33% <ø> (ø)
src/data/services/LmsApiService.js 33.92% <12.50%> (-1.08%) ⬇️
src/components/settings/SettingsTabs.jsx 87.87% <80.00%> (-2.45%) ⬇️
.../settings/SettingsApiCredentialsTab/CopyButton.jsx 92.85% <92.85%> (ø)
src/components/settings/HelpCenterButton.jsx 100.00% <100.00%> (ø)
...s/SettingsApiCredentialsTab/APICredentialsPage.jsx 100.00% <100.00%> (ø)
...nts/settings/SettingsApiCredentialsTab/Context.jsx 100.00% <100.00%> (ø)
...settings/SettingsApiCredentialsTab/CopiedToast.jsx 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 25, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @yuanyuan-git-tech! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211 mphilbrick211 removed the open-source-contribution PR author is not from Axim or 2U label Aug 28, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2023
@kiram15 kiram15 removed the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2023
@kiram15 kiram15 removed the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 1, 2023
@openedx-webhooks
Copy link

@yuanyuan-git-tech Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants