Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show exec-ed learner credit only for exec ed offers #1021

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

zamanafzal
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc3a70f) 83.21% compared to head (d2c1b3d) 83.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   83.21%   83.22%           
=======================================
  Files         400      400           
  Lines        8698     8702    +4     
  Branches     1797     1799    +2     
=======================================
+ Hits         7238     7242    +4     
  Misses       1422     1422           
  Partials       38       38           
Files Changed Coverage Δ
...omponents/learner-credit-management/BudgetCard.jsx 100.00% <100.00%> (ø)
...onents/learner-credit-management/data/constants.js 100.00% <100.00%> (ø)
...components/learner-credit-management/data/utils.js 92.85% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zamanafzal zamanafzal merged commit 4266584 into master Aug 22, 2023
6 checks passed
@zamanafzal zamanafzal deleted the zafzal/ENT-7516 branch August 22, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants