Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show one card on learner credit screen #1022

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

zamanafzal
Copy link
Member

@zamanafzal zamanafzal commented Aug 24, 2023

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only

Screen Shot 2023-08-24 at 4 17 32 PM
Screen Shot 2023-08-24 at 4 17 51 PM

if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.34% ⚠️

Comparison is base (4266584) 83.22% compared to head (1211922) 82.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   83.22%   82.88%   -0.34%     
==========================================
  Files         400      401       +1     
  Lines        8702     8730      +28     
  Branches     1799     1801       +2     
==========================================
- Hits         7242     7236       -6     
- Misses       1422     1455      +33     
- Partials       38       39       +1     
Files Changed Coverage Δ
...earner-credit-management/MultipleBudgetsPicker.jsx 50.00% <ø> (ø)
...onents/learner-credit-management/BudgetCard-V2.jsx 100.00% <100.00%> (ø)
...credit-management/LearnerCreditAllocationTable.jsx 94.11% <100.00%> (-0.33%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zamanafzal zamanafzal merged commit 9af4648 into master Aug 24, 2023
5 of 6 checks passed
@zamanafzal zamanafzal deleted the zafzal/lcm-change-cards branch August 24, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants