Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add feature flag AUTH0_SELF_SERVICE_INTEGRATION #1024

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

Inserting a placeholder for the new SSO stepper, activated using new feature flag AUTH0_SELF_SERVICE_INTEGRATION

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (ef1692d) 82.88% compared to head (b9e97b1) 82.89%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   82.88%   82.89%   +0.01%     
==========================================
  Files         401      402       +1     
  Lines        8727     8735       +8     
  Branches     1800     1805       +5     
==========================================
+ Hits         7233     7241       +8     
  Misses       1455     1455              
  Partials       39       39              
Files Changed Coverage Δ
...onents/learner-credit-management/BudgetCard-V2.jsx 100.00% <ø> (ø)
.../learner-credit-management/MultipleBudgetsPage.jsx 81.81% <ø> (ø)
...earner-credit-management/MultipleBudgetsPicker.jsx 50.00% <ø> (ø)
...credit-management/LearnerCreditAllocationTable.jsx 95.23% <100.00%> (+1.12%) ⬆️
...nents/settings/SettingsSSOTab/NewSSOConfigForm.jsx 85.71% <100.00%> (+5.71%) ⬆️
...mponents/settings/SettingsSSOTab/NewSSOStepper.jsx 100.00% <100.00%> (ø)
src/config/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there's a rebase conflict but lgtm otherwise!

@marlonkeating marlonkeating merged commit 31f4dc8 into master Sep 1, 2023
5 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-7580 branch September 1, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants