Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate API Credentials in Admin Portal #1027

Merged
merged 19 commits into from
Sep 8, 2023
Merged

feat: generate API Credentials in Admin Portal #1027

merged 19 commits into from
Sep 8, 2023

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 8, 2023

https://2u-internal.atlassian.net/browse/ENT-7335

Continuation of this branch #1018. TLDR is Yuanyuan's permissions got revoked when she left so I had to create a new PR.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots
Screenshot 2023-09-08 at 9 28 58 AM Screenshot 2023-09-08 at 9 33 49 AM

@kiram15 kiram15 requested a review from a team September 8, 2023 15:34
Copy link
Contributor

@marlonkeating marlonkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per my review of the parent branch: #1018

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 92.37% and project coverage change: +0.12% 🎉

Comparison is base (31f4dc8) 82.89% compared to head (9292c57) 83.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   82.89%   83.01%   +0.12%     
==========================================
  Files         402      412      +10     
  Lines        8735     8850     +115     
  Branches     1805     1822      +17     
==========================================
+ Hits         7241     7347     +106     
- Misses       1455     1464       +9     
  Partials       39       39              
Files Changed Coverage Δ
.../components/ContactCustomerSupportButton/index.jsx 100.00% <ø> (ø)
src/components/settings/SettingsLMSTab/index.jsx 95.45% <ø> (ø)
src/data/reducers/portalConfiguration.js 73.33% <ø> (ø)
src/data/services/LmsApiService.js 33.92% <12.50%> (-1.08%) ⬇️
src/components/settings/SettingsTabs.jsx 87.87% <80.00%> (-2.45%) ⬇️
.../settings/SettingsApiCredentialsTab/CopyButton.jsx 92.85% <92.85%> (ø)
src/components/settings/HelpCenterButton.jsx 100.00% <100.00%> (ø)
...s/SettingsApiCredentialsTab/APICredentialsPage.jsx 100.00% <100.00%> (ø)
...nts/settings/SettingsApiCredentialsTab/Context.jsx 100.00% <100.00%> (ø)
...settings/SettingsApiCredentialsTab/CopiedToast.jsx 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 4da552c into master Sep 8, 2023
11 checks passed
@kiram15 kiram15 deleted the kiram15/7335 branch September 8, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants