fix: remove broken usage of useCache from getSubsidyRequestConfiguration #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return EnterpriseAccessApiService.apiClient({ | ||
| useCache: configuration.USE_API_CACHE, | ||
| }).get(url, { clearCacheEntry }); | ||
| return EnterpriseAccessApiService.apiClient().get(url, { clearCacheEntry }); |
There was a problem hiding this comment.
[curious] If this API call never uses useCache anymore, is the clearCacheEntry logic necessary anymore in this function's signature, passed to this get function, or in the caller(s) of getSubsidyRequestConfiguration?
Hmm, yeah seems likely especially around the mention of "Usages of clearCacheEntry will have to be updated."... probably something that we missed 🙃 |
iloveagent57
force-pushed
the
aed/ent-7696
branch
from
9f40a44
to
7781e81
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
+ Coverage 82.89% 83.01% +0.11%
==========================================
Files 402 412 +10
Lines 8735 8849 +114
Branches 1805 1820 +15
==========================================
+ Hits 7241 7346 +105
- Misses 1455 1464 +9
Partials 39 39
☔ View full report in Codecov by Sentry. |
iloveagent57
force-pushed
the
aed/ent-7696
branch
from
7781e81
to
f0f8189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where updates to course requests settings weren't reflected in the Settings/Access page. We were previously setting
useCacheto always be true in the call to fetch subsidy request configs.Broken behavior was possibly related to this change? openedx/frontend-platform#361
Only if submitting a visual change