Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: show all enterprise budgets regardless of plan and route correctly #1031

Closed
wants to merge 4 commits into from

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Sep 15, 2023

Description
This PR covers up the following points

  • All budgets of ecommerce offers and learner-credit offers are showing regardless of plan.
  • View Budget button takes the learner to the detail page along with offerId/budgetId
  • Create two new routes
    • for e-commerce /:enterpriseSlug/admin/learner-credit/:offerId
    • for learner_credit budget /:enterpriseSlug/admin/learner-credit/:budgetId
  • Fetch the enrollments on the basis of budget_id if present otherwise, fetch enrollments on the base of offer_id on the detail page
  • The “Budgets” link in the breadcrumbs on the LCM UI relies on react-router’s Link component and avoids a full-page refresh.

JIRA -> [ENT-7672, ENT-7673, ENT-7674, ENT-7565]

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@jajjibhai008 jajjibhai008 changed the title feat: show all enterprise budgets regardless of plan and route correctly [WIP] feat: show all enterprise budgets regardless of plan and route correctly Sep 15, 2023
@mahamakifdar19 mahamakifdar19 force-pushed the eahmadjaved/ENT-7672-7673 branch 3 times, most recently from b7a7e8c to 339685d Compare September 19, 2023 09:42
fix: full page refresh issue when clicking 'Budgets', added test coverage and fixed lint issues
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (eahmadjaved/ENT-7660@4da552c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 39eeab2 differs from pull request most recent head 2b0d6a5. Consider uploading reports for the commit 2b0d6a5 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##             eahmadjaved/ENT-7660    #1031   +/-   ##
=======================================================
  Coverage                        ?   82.97%           
=======================================================
  Files                           ?      414           
  Lines                           ?     8881           
  Branches                        ?     1832           
=======================================================
  Hits                            ?     7369           
  Misses                          ?     1471           
  Partials                        ?       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants