-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose enterpriseFeatures
from API in portalConfiguration
#1039
Conversation
portalConfiguration
enterpriseFeatures
from API in portalConfiguration
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 412 412
Lines 8849 8849
Branches 1820 1819 -1
=======================================
Hits 7346 7346
Misses 1464 1464
Partials 39 39
☔ View full report in Codecov by Sentry. |
@@ -34,7 +37,7 @@ const fetchPortalConfiguration = slug => ( | |||
dispatch(fetchPortalConfigurationRequest()); | |||
return LmsApiService.fetchEnterpriseBySlug(slug) | |||
.then((response) => { | |||
dispatch(fetchPortalConfigurationSuccess(response.data)); | |||
dispatch(fetchPortalConfigurationSuccess(response)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[context] We want to all of response
now that it contains both data
(i.e., the actively viewed enterprise customer metadata) and enterpriseFeatures
(i.e., the Waffled-based feature flags).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Stores
enterpriseFeatures
from existing API integration in theportalConfiguration
reducer within the application's Redux store. To retrieve theenterpriseFeatures
within one of the child components ofEnterprisePage
:Example
enterpriseFeatures
objecthttps://courses.stage.edx.org/enterprise/api/v1/enterprise-customer/dashboard_list/?page=1&page_size=50&enterprise_slug=exec-ed-2u-integration-qa
Example API response:
For all changes
Only if submitting a visual change