Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add @openedx in renovate automate configuration #1045

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Oct 2, 2023

Description

Add @openedx in renovate automate configuration.

Ticket

Create common renovate config that automates @edx and @openedx namespaced minor/patch version upgrades

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@Mashal-m Mashal-m self-assigned this Oct 2, 2023
@Mashal-m Mashal-m marked this pull request as draft October 2, 2023 12:12
@adamstankiewicz
Copy link
Member

@Mashal-m Looks like CI is failing on the same underlying test failures causing all PR's CI to fail currently...I see you fixed that test to use a mocked date instead in this other PR's commit here.

If you'd like to this PR over the line quickest, it might be good to copy that linked change over into this PR so that it can merge independently.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review October 3, 2023 08:49
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9cc4dad) 82.90% compared to head (e4bebbb) 82.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   82.90%   82.90%   -0.01%     
==========================================
  Files         415      415              
  Lines        8933     8932       -1     
  Branches     1832     1833       +1     
==========================================
- Hits         7406     7405       -1     
  Misses       1485     1485              
  Partials       42       42              
Files Coverage Δ
...components/learner-credit-management/data/utils.js 95.91% <100.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 merged commit 47938ad into master Oct 3, 2023
6 checks passed
@BilalQamar95 BilalQamar95 deleted the mashal-m/update-renovate-configuration branch October 3, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants