fix: cleaning up sso self service wording and behaviors #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7985
branch
from
c102af8
to
37de1eb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 84.69% 84.71% +0.01%
==========================================
Files 476 476
Lines 9958 9968 +10
Branches 2083 2089 +6
==========================================
+ Hits 8434 8444 +10
Misses 1483 1483
Partials 41 41 ☔ View full report in Codecov by Sentry. |
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7985
branch
from
37de1eb
to
69b6de2
Compare
marlonkeating
approved these changes
Nov 20, 2023
Comment on lines
+112
to
+114
| act(() => { | ||
| userEvent.click(screen.getByTestId(`existing-sso-config-card-dropdown-${inactiveConfig[0].id}`)); | ||
| }); |
There was a problem hiding this comment.
Why is act() needed here? It was my understanding that @testing-library/react userEvent operations are already wrapped in act().
There was a problem hiding this comment.
I was just following and fixing the warnings printed out by the tests, I believe it has to do with updates triggered by the click and not just the click itself? However I'm not entirely sure
src/components/settings/SettingsSSOTab/tests/NewSSOConfigForm.test.jsx
Outdated
Show resolved
Hide resolved
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7985
branch
from
69b6de2
to
2305f1a
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-7985
branch
from
2305f1a
to
15b95a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change