-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-8491] Implement Base Link Learners modal #1184
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 85.38% 85.44% +0.06%
==========================================
Files 498 505 +7
Lines 10864 11023 +159
Branches 2291 2318 +27
==========================================
+ Hits 9276 9419 +143
- Misses 1544 1560 +16
Partials 44 44 ☔ View full report in Codecov by Sentry. |
src/components/learner-credit-management/empty-state/NoBnEBudgetActivity.jsx
Outdated
Show resolved
Hide resolved
<Button variant="tertiary" onClick={handleCloseInviteModal}>Cancel</Button> | ||
<StatefulButton | ||
labels={{ | ||
default: 'Invite', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we break out the button states into constant(s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think personally it would make it less readable, and I wanted to follow the pattern set from this
Line 241 in 135cb6e
pending: 'Assigning...', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, worth nothing that if/when i18n is introduced into this MFE, any English strings stored in constants will need to be replaced with intl.formatMessage
or FormattedMessage
, etc.
src/components/learner-credit-management/invite-modal/InviteMembersModalWrapper.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/invite-modal/InviteModalContent.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetDetailActivityTabContents.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/BudgetDetailActivityTabContents.jsx
Outdated
Show resolved
Hide resolved
<Button variant="tertiary" onClick={handleCloseInviteModal}>Cancel</Button> | ||
<StatefulButton | ||
labels={{ | ||
default: 'Invite', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, worth nothing that if/when i18n is introduced into this MFE, any English strings stored in constants will need to be replaced with intl.formatMessage
or FormattedMessage
, etc.
src/components/learner-credit-management/invite-modal/InviteMembersModalWrapper.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/invite-modal/InviteModalSummary.jsx
Show resolved
Hide resolved
src/components/learner-credit-management/tests/BudgetDetailPage.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/invite-modal/InviteMembersModalWrapper.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/invite-modal/InviteMembersModalWrapper.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/invite-modal/InviteMembersModalWrapper.jsx
Outdated
Show resolved
Hide resolved
49eb6c2
to
ea68dc8
Compare
Co-authored-by: Marlon Keating <[email protected]>
…min-portal into kiram15/ENT-8491
This is the first pass at the invite learner modal for groups. This work includes the validation of the emails (duplicates allowed at this point but warned against), misformatted should surface an error and block.
Jira ticket
Screen.Recording.2024-03-11.at.4.27.18.PM.mov
For all changes
Only if submitting a visual change