Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formdata email parsing error fix #1186

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: formdata email parsing error fix #1186

merged 2 commits into from
Mar 20, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Mar 19, 2024

@kiram15 kiram15 requested a review from a team March 19, 2024 21:52
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (37e3151) to head (0c1c27f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   85.44%   85.46%   +0.01%     
==========================================
  Files         505      505              
  Lines       11023    11025       +2     
  Branches     2318     2318              
==========================================
+ Hits         9419     9422       +3     
+ Misses       1560     1559       -1     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marlonkeating marlonkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, though it would be good to add unit testing that could detect similar issues in the future. If that's too heavy a lift given the speed we want to get this fix out, that's fine, but we should at least note this for future Tech Debt work.

@kiram15 kiram15 merged commit c7dd327 into master Mar 20, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-8657 branch March 20, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants