Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding in duplicate entry support #1189

Merged
merged 5 commits into from
Mar 26, 2024
Merged

feat: adding in duplicate entry support #1189

merged 5 commits into from
Mar 26, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Mar 25, 2024

Rendering blue "info" non-blocking warnings related to having duplicate emails in both csv and input entry.
https://github.com/openedx/frontend-app-admin-portal/assets/31229189/94ecb853-9fc3-4fc6-9b82-f8e228c289a1

Jira ticket here

@kiram15 kiram15 requested a review from a team March 25, 2024 06:38
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.47%. Comparing base (0b37fcf) to head (817f79c).

Files Patch % Lines
...ents/learner-credit-management/cards/data/utils.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         506      508    +2     
  Lines       11053    11060    +7     
  Branches     2328     2326    -2     
=======================================
+ Hits         9448     9454    +6     
- Misses       1561     1562    +1     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marlonkeating marlonkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kiram15 kiram15 merged commit ab124ae into master Mar 26, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-8496 branch March 26, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants