feat: Conditionally render expiring learner credit alerts and modals #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
approved these changes
May 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
+ Coverage 85.37% 85.39% +0.01%
==========================================
Files 537 537
Lines 11672 11684 +12
Branches 2462 2430 -32
==========================================
+ Hits 9965 9977 +12
Misses 1657 1657
Partials 50 50 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
May 21, 2024
src/components/BudgetExpiryAlertAndModal/data/hooks/useExpiry.jsx
Outdated
Show resolved
Hide resolved
| return { endDate, expected: expiryThresholds[0]({ date: formatDate(endDate.toString()) }) }; | ||
| })(), | ||
| ])('displays correct notification and modal when plan is expiring in %s days', ({ endDate, expected }) => { | ||
| { |
There was a problem hiding this comment.
[kudos] Nice clean up on the it.each syntax :)
| @@ -89,6 +89,5 @@ describe('<ContentHighlights>', () => { | |||
| data: { results: [{ applies_to_all_contexts: true }] }, | |||
| })); | |||
| renderWithRouter(<ContentHighlightsWrapper location={{ state: {} }} />); | |||
| screen.debug(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally renders expiration modal and alert if the enterprise customer field
disable_expiry_messaging_for_learner_creditis toggled.Screen.Recording.2024-05-16.at.12.38.47.PM.mov
Screen.Recording.2024-05-16.at.12.40.07.PM.mov
For all changes
Only if submitting a visual change