fix: assorted groups bug fixes #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
+ Coverage 85.35% 85.43% +0.08%
==========================================
Files 537 537
Lines 11709 11739 +30
Branches 2478 2457 -21
==========================================
+ Hits 9994 10029 +35
+ Misses 1664 1658 -6
- Partials 51 52 +1 ☔ View full report in Codecov by Sentry. |
marlonkeating
approved these changes
May 21, 2024
Comment on lines
17
to
20
| const { data: appliesToAllContexts } = useEnterpriseGroup(subsidyAccessPolicy); | ||
|
|
||
| const catalogGroupView = subsidyAccessPolicy?.groupAssociations?.length > 0 | ||
| && !appliesToAllContexts.appliesToAllContexts; |
There was a problem hiding this comment.
nit
Suggested change
| const { data: appliesToAllContexts } = useEnterpriseGroup(subsidyAccessPolicy); | |
| const catalogGroupView = subsidyAccessPolicy?.groupAssociations?.length > 0 | |
| && !appliesToAllContexts.appliesToAllContexts; | |
| const { data: { appliesToAllContexts } } = useEnterpriseGroup(subsidyAccessPolicy); | |
| const catalogGroupView = subsidyAccessPolicy?.groupAssociations?.length > 0 | |
| && !appliesToAllContexts; |
| @@ -12,7 +12,7 @@ import LmsApiService from '../../../../data/services/LmsApiService'; | |||
| * @returns The enterprise group object | |||
| */ | |||
| const getEnterpriseGroup = async ({ subsidyAccessPolicy }) => { | |||
| if (!subsidyAccessPolicy.groupAssociations || isEmpty(subsidyAccessPolicy.groupAssociations)) { | |||
| if (subsidyAccessPolicy === undefined || isEmpty(subsidyAccessPolicy.groupAssociations)) { | |||
There was a problem hiding this comment.
nit
Suggested change
| if (subsidyAccessPolicy === undefined || isEmpty(subsidyAccessPolicy.groupAssociations)) { | |
| if (isEmpty(subsidyAccessPolicy?.groupAssociations)) { |
There was a problem hiding this comment.
If the policy didn't have any group associations, with the ? it would return undefined, and isEmpty(undefined) == false ramda/ramda#2507
There was a problem hiding this comment.
We're using lodash's isEmpty here, and when I tried it out on the lodash site, passing in undefined resulted in true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple changes in this PR - Jira ticket
For all changes
Only if submitting a visual change