Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add removed members count #1234

Merged
merged 5 commits into from
May 23, 2024
Merged

feat: add removed members count #1234

merged 5 commits into from
May 23, 2024

Conversation

katrinan029
Copy link
Contributor

Description

Adds the removed learners count to toggle in the Members tab when there are removed members.
https://2u-internal.atlassian.net/browse/ENT-8968

UI Updates

figma before after
Screenshot 2024-05-22 at 2 11 05 PM Screenshot 2024-05-22 at 2 13 14 PM Screenshot 2024-05-22 at 2 11 59 PM

Test plan

  1. checkout branch knguyen2/ent-8968. in your terminal, run the follow commands:
    • git fetch
    • git checkout knguyen2/ent-8968
    • npm run start:stage
  2. use staging link https://localhost.stage.edx.org:1991/exec-ed-2u-integration-qa/admin/learner-credit/92fa52bc-6863-49ff-8a32-1cfefbfbb728/members to verify that the count of removed learners is in the toggle
  3. confirm that when toggled is on, the removed learner should appear in the data table
    Screenshot 2024-05-22 at 2 18 25 PM
  4. verify changes match figma mocks
    https://www.figma.com/design/H69Met5YL7xu5w5LRliumQ/Groups-MVP?node-id=4289-23202&t=0DKGA6qrlzZz0EyD-0

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 self-requested a review May 23, 2024 15:53
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 35.89744% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 85.26%. Comparing base (4861bd3) to head (dcd9c5d).

Files Patch % Lines
...ent/data/hooks/useEnterpriseRemovedGroupMembers.js 4.16% 20 Missing and 3 partials ⚠️
...ent/members-tab/BudgetDetailMembersTabContents.jsx 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
- Coverage   85.43%   85.26%   -0.18%     
==========================================
  Files         537      538       +1     
  Lines       11739    11773      +34     
  Branches     2495     2497       +2     
==========================================
+ Hits        10029    10038       +9     
- Misses       1657     1678      +21     
- Partials       53       57       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit 957a425 into master May 23, 2024
4 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8968 branch May 23, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants