Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8956] - fix: missing href on xml download button #1259

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

hamzawaleed01
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (e74391e) to head (e8d7c53).

Files Patch % Lines
src/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   85.38%   85.38%   -0.01%     
==========================================
  Files         545      545              
  Lines       11970    11971       +1     
  Branches     2560     2563       +3     
==========================================
  Hits        10221    10221              
  Misses       1691     1691              
- Partials       58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env.development Outdated
@@ -57,3 +57,4 @@ PLOTLY_SERVER_URL='http://localhost:8050'
AUTH0_SELF_SERVICE_INTEGRATION='true'
MFE_CONFIG_API_URL='http://localhost:18000/api/mfe_config/v1'
DEMO_ENTEPRISE_UUID='set a valid enterprise uuid'
EDX_ACCESS_URL='http://localhost:1991'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameenfatima78 @zamanafzal we don't have this service in local env. What should be the default url here then? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering which service is this pointing to? Does it have a repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it's private - managed by auth team.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added the base url of its own (frontend-app-admin-portal)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting it to testing env of auth service which is http://2u-guid-dev.us.auth0.com/

.env.development Outdated Show resolved Hide resolved
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8956-fix-xml-download-btn branch from 5aaf404 to 77731c5 Compare July 1, 2024 13:32
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8956-fix-xml-download-btn branch from 77731c5 to e8d7c53 Compare July 1, 2024 13:35
@hamzawaleed01 hamzawaleed01 merged commit fbfdbab into master Jul 2, 2024
5 of 6 checks passed
@hamzawaleed01 hamzawaleed01 deleted the ENT-8956-fix-xml-download-btn branch July 2, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants