-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-8956] - fix: missing href on xml download button #1259
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 85.38% 85.38% -0.01%
==========================================
Files 545 545
Lines 11970 11971 +1
Branches 2560 2563 +3
==========================================
Hits 10221 10221
Misses 1691 1691
- Partials 58 59 +1 ☔ View full report in Codecov by Sentry. |
8e3774a
to
116e2e5
Compare
.env.development
Outdated
@@ -57,3 +57,4 @@ PLOTLY_SERVER_URL='http://localhost:8050' | |||
AUTH0_SELF_SERVICE_INTEGRATION='true' | |||
MFE_CONFIG_API_URL='http://localhost:18000/api/mfe_config/v1' | |||
DEMO_ENTEPRISE_UUID='set a valid enterprise uuid' | |||
EDX_ACCESS_URL='http://localhost:1991' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameenfatima78 @zamanafzal we don't have this service in local env. What should be the default url here then? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering which service is this pointing to? Does it have a repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it's private - managed by auth team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added the base url of its own (frontend-app-admin-portal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting it to testing env of auth service which is http://2u-guid-dev.us.auth0.com/
116e2e5
to
8641d2c
Compare
8641d2c
to
59529b4
Compare
src/components/settings/SettingsSSOTab/steps/NewSSOConfigAuthorizeStep.tsx
Show resolved
Hide resolved
5aaf404
to
77731c5
Compare
…o ENT-8956-fix-xml-download-btn
77731c5
to
e8d7c53
Compare
For all changes
Only if submitting a visual change