Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9206] - bulk-revoke endpoint changes #1295

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

hamzawaleed01
Copy link
Member

@hamzawaleed01 hamzawaleed01 commented Sep 6, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots
Screen.Recording.2024-09-06.at.3.50.35.PM.mov

@hamzawaleed01 hamzawaleed01 changed the title Ent 9206/bulk revoke endpoint changes [ENT-9206] - bulk-revoke endpoint changes Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (f28dc42) to head (6ed8336).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...eManagementModals/LicenseManagementRevokeModal.jsx 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   85.48%   85.50%   +0.01%     
==========================================
  Files         564      564              
  Lines       12305    12325      +20     
  Branches     2564     2602      +38     
==========================================
+ Hits        10519    10538      +19     
  Misses       1728     1728              
- Partials       58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/bulk-revoke-endpoint-changes branch from 77c1641 to 2331be6 Compare September 6, 2024 11:08
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/bulk-revoke-endpoint-changes branch from 2331be6 to b12b58c Compare September 6, 2024 11:11
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but approved it.

@hamzawaleed01 hamzawaleed01 merged commit 24478cf into master Sep 10, 2024
6 checks passed
@hamzawaleed01 hamzawaleed01 deleted the ENT-9206/bulk-revoke-endpoint-changes branch September 10, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants