Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading charts height issue #1297

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Sep 11, 2024

Description
we were facing a chart height issue while we loaded data. So, this PR is fixing the height of the charts so that it looks consistent in all states.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19
Copy link
Contributor

@jajjibhai008 Can you please add some description and a UI screenshot if possible?

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (2465202) to head (e379755).
Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files         564      564           
  Lines       12351    12351           
  Branches     2581     2621   +40     
=======================================
  Hits        10563    10563           
+ Misses       1730     1729    -1     
- Partials       58       59    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 115c430 into master Sep 11, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9401-fix branch September 11, 2024 08:51
@muhammad-ammar muhammad-ammar added the plotly-migration Work to migrate from Plotly DASH to PlotlyJS label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotly-migration Work to migrate from Plotly DASH to PlotlyJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants