-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Moved enrollments charts to new API endpoint. #1298
Conversation
7101e5e
to
c1b14b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 85.52% 85.60% +0.07%
==========================================
Files 564 566 +2
Lines 12351 12467 +116
Branches 2621 2641 +20
==========================================
+ Hits 10563 10672 +109
- Misses 1729 1737 +8
+ Partials 59 58 -1 ☔ View full report in Codecov by Sentry. |
package.json
Outdated
@@ -41,13 +41,14 @@ | |||
"@tanstack/react-query": "4.36.1", | |||
"@tanstack/react-query-devtools": "4.36.1", | |||
"algoliasearch": "4.8.3", | |||
"axios": "^1.7.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain the reason behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting an error of missing axios
while it being used in the code. So, I added this to fix that.
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseEnrollmentsData.js
Show resolved
Hide resolved
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseEnrollmentsData.js
Outdated
Show resolved
Hide resolved
653055d
to
97d3d53
Compare
97d3d53
to
5235e25
Compare
Jira Ticket: ENT-9420
Description:
Updated frontend logic according to the backend changes made in openedx/edx-enterprise-data#489
For all changes
Only if submitting a visual change