Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs related to variant release #1307

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

brobro10000
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@9ce37c3). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...components/learner-credit-management/data/utils.js 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1307   +/-   ##
=========================================
  Coverage          ?   85.56%           
=========================================
  Files             ?      567           
  Lines             ?    12598           
  Branches          ?     2675           
=========================================
  Hits              ?    10780           
  Misses            ?     1756           
  Partials          ?       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 marked this pull request as ready for review September 18, 2024 14:04
@brobro10000 brobro10000 merged commit 6c82806 into master Sep 18, 2024
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-variant-bug-bash branch September 18, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants