Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9538]: Make analytics V2 skills scatter chart bubble marker size consistent with V1 #1324

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Oct 1, 2024

Ticket
https://2u-internal.atlassian.net/browse/ENT-9538

Description
In Analytics V2, the marker size for skills scatter chart is not similar to what we have in scatter chart in V1.
This PR addresses this issues and incorporates changes to make the bubble marker size consistent with V1.

Screenshots

APSCHE V2 Before
AP Before

APSCHE V2 After
AP - After

5CA V2 Before
5CA - Before

5CA V2 After
5CA - After

PP V2 Before
PP - Before

PP V2 After
PP - After

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (8f8b447) to head (9421035).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/components/AdvanceAnalyticsV2/data/utils.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         576      576           
  Lines       12686    12697   +11     
  Branches     2689     2649   -40     
=======================================
+ Hits        10861    10871   +10     
- Misses       1764     1766    +2     
+ Partials       61       60    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit b06faa9 into master Oct 3, 2024
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9538 branch October 3, 2024 07:15
@mahamakifdar19 mahamakifdar19 added the plotly-migration Work to migrate from Plotly DASH to PlotlyJS label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotly-migration Work to migrate from Plotly DASH to PlotlyJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants