-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video editor supports transcripts (minimal version) #1352
Comments
@jmakowski1123 @ormsbee What's the priority of this relative to the list of bugs we have? Should we do a minimal version of this as a bugfix? e.g. "ensure transcripts continue working when a video component is pasted into a library". |
My take on it is that we leave Video transcripts in its not-so-great state for Sumac and focus on other bugs. I'd like to take some more time to examine how to take a (backwards compatible) flamethrower through a lot of the existing transcripts code rather than trying to stuff 1:1-ish parity into Sumac. |
Taking a flamethrower to the transcripts code sounds like a great plan to me. |
Does the flamethrower approach mean transcripts won't work in pasted content? |
@jmakowski1123: I believe there are three or four different ways to specify transcripts today, they get auto-converted between three internal formats, and there are hard-coded, VideoBlock-level assumptions about where those transcripts live. Some of those work today (two where transcripts are listed explicitly via edxval or in the block itself, but using only the SRT file format). I think this is the most common way to specify transcripts now. But the oldest convention that assumes SRT files are in the root files and uploads directory probably won't work, srt.json files won't work. etc. Even describing the compatibility matrix is complex because this code is that crazy. I think we'll want to do some sort of data transformation to convert this into the most modern format rather than supporting the matrix of previous formats. We might even use this chance to switchover to VTT, which we've wanted to do for years. But that needs time and planning to work out. |
Got it. We can get away with no transcript support for Sumac, as long as we message it. I created a ticket to change the text (or remove the field entirely) for now. #1453 |
@jmakowski1123 I edited the requirements for this ticket. Can you please review it? ^ |
This ticket is for bare-minimum transcript support in video components:
Note what this excludes: if you create a non-Youtube video in a library, it may not be possible to upload a transcript manually via the editor. Though if that's easy to implement it would be a nice improvement to include.
The text was updated successfully, but these errors were encountered: