fix: add component to collection on paste [FC-0062] #1450
Conversation
Link component to collection if pasted in a collection page
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
+ Coverage 93.25% 93.27% +0.02%
==========================================
Files 1052 1052
Lines 20458 20465 +7
Branches 4371 4369 -2
==========================================
+ Hits 19078 19089 +11
+ Misses 1317 1313 -4
Partials 63 63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
👍 Works perfectly @navinkarkera :)
- I tested this on my tutor dev stack by testing pasting components into a collection, and creating new components in a collection.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A - User-facing strings are extracted for translation
| @@ -179,10 +188,8 @@ const AddContentContainer = () => { | |||
| blockType, | |||
| definitionId: `${uuid4()}`, | |||
| }).then((data) => { | |||
| linkComponent(data.id); | |||
There was a problem hiding this comment.
Thank you for fixing the "create block in collection" issue here too @navinkarkera ! 🚀
Link component to collection if pasted in a collection page. Fixes: openedx#1435 (cherry picked from commit 549dbaa)
Description
Link component to collection if pasted in a collection page.
Supporting information
Private-ref: FAL-3922Testing instructions