Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show Programs button if programs are not configured #372

Open
arbrandes opened this issue Jul 5, 2024 · 1 comment
Open

Don't show Programs button if programs are not configured #372

arbrandes opened this issue Jul 5, 2024 · 1 comment
Assignees
@arbrandes
Labels
bug Report of or fix for something that isn't working as intended release blocker Blocks the upcoming release (fix needed) waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Milestone
Redwood.2

Comments

@arbrandes
Copy link
Contributor

Description

On a bare installation one sees the Programs button even though no programs are configured in the backend:

image

The result is a 404 if you click it:

image

Expected behavior

If no programs are configured in the backend, the button should simply not show.

Implementation

While we could implement this as a config variable, ideally the frontend would detect whether programs are enabled and render the button based on that.
@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Jul 5, 2024
@arbrandes arbrandes added this to the Redwood.2 milestone Jul 5, 2024
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 12, 2024
@justinhynes
Copy link
Contributor

Thanks for the report! Aperture will track this internally as https://2u-internal.atlassian.net/browse/APER-3565. We will discuss this ticket in our next grooming session.

@justinhynes justinhynes removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 17, 2024
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 17, 2024
@dcoa dcoa mentioned this issue Sep 28, 2024
Merged
@mariajgrimaldi mariajgrimaldi added the release blocker Blocks the upcoming release (fix needed) label Oct 18, 2024
@dcoa dcoa mentioned this issue Oct 18, 2024
Open
@arbrandes arbrandes self-assigned this Oct 23, 2024
@mariajgrimaldi mariajgrimaldi added release blocker Blocks the upcoming release (fix needed) and removed release blocker Blocks the upcoming release (fix needed) labels Oct 28, 2024
@deborahgu deborahgu added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbrandes arbrandes

Labels
bug Report of or fix for something that isn't working as intended release blocker Blocks the upcoming release (fix needed) waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Aperture-Maintained
Status: Backlog
Build-Test-Release Working Group
Status: In progress
Frontend Working Group
Status: Backlog
Milestone
Redwood.2
Development

No branches or pull requests
4 participants
@deborahgu @arbrandes @justinhynes @mariajgrimaldi