Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8962] Added video section on video detail page #1115

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Jul 12, 2024

Jira Ticket:
https://2u-internal.atlassian.net/browse/ENT-8962

Description
Implemented the video section on the video detail page using video.js
Screen recordings are attached under ENT-8962 due to GitHub's file size limitations but here's a shorter screen recording clip:

video_sreenrecording.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 92.79279% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.89%. Comparing base (d8b2c99) to head (c8621ea).
Report is 7 commits behind head on master.

Files Patch % Lines
src/components/app/routes/createAppRouter.jsx 0.00% 3 Missing ⚠️
src/components/microlearning/VideoDetailPage.jsx 86.36% 3 Missing ⚠️
src/components/app/data/queries/queryKeyFactory.js 50.00% 1 Missing ⚠️
src/components/video/data/service.js 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   86.49%   86.89%   +0.40%     
==========================================
  Files         380      388       +8     
  Lines        7871     8022     +151     
  Branches     1896     1959      +63     
==========================================
+ Hits         6808     6971     +163     
+ Misses       1011     1002       -9     
+ Partials       52       49       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/components/microlearning/data/utils.js Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
src/components/microlearning/styles/VideoDetailPage.scss Outdated Show resolved Hide resolved
@saleem-latif
Copy link
Contributor

@mahamakifdar19 Please also attach some screenshots to this PR, I know videos are attached but not everyone access to this repo might have access to JIRA ticket.

@mahamakifdar19 mahamakifdar19 merged commit b756e97 into master Jul 22, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8962 branch July 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants