-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-8962] Added video section on video detail page #1115
Conversation
0f99e70
to
255179f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 86.49% 86.89% +0.40%
==========================================
Files 380 388 +8
Lines 7871 8022 +151
Branches 1896 1959 +63
==========================================
+ Hits 6808 6971 +163
+ Misses 1011 1002 -9
+ Partials 52 49 -3 ☔ View full report in Codecov by Sentry. |
@mahamakifdar19 Please also attach some screenshots to this PR, I know videos are attached but not everyone access to this repo might have access to JIRA ticket. |
255179f
to
c8621ea
Compare
Jira Ticket:
https://2u-internal.atlassian.net/browse/ENT-8962
Description
Implemented the video section on the video detail page using video.js
Screen recordings are attached under ENT-8962 due to GitHub's file size limitations but here's a shorter screen recording clip:
video_sreenrecording.mov
For all changes
Only if submitting a visual change