Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adhere to hideCourseOriginalPrice in upgrade/enroll confirmation modal #1117

Merged
merged 13 commits into from
Jul 15, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jul 15, 2024

Description

On the EnrollModal component (enrollment/upgrade confirmation modal across all subsidies), conditionally include the price based on the enterprise customer config hideCourseOriginalPrice.

Note: This only impacts legacy enterprise offers, which is referred to as "learner credit" here, despite not relating to new learner credit.

Screenshots

With price (hideCourseOriginalPrice=false)

image

Without price (hideCourseOriginalPrice=true)

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (00a9728) to head (3bb6593).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   86.56%   86.59%   +0.02%     
==========================================
  Files         380      380              
  Lines        7914     7916       +2     
  Branches     1943     1937       -6     
==========================================
+ Hits         6851     6855       +4     
+ Misses       1011     1009       -2     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz changed the title fix: adhere to hide_original_course_price in upgrade/enroll confirmation modal fix: adhere to hideCourseOriginalPrice in upgrade/enroll confirmation modal Jul 15, 2024
@adamstankiewicz adamstankiewicz changed the title fix: adhere to hideCourseOriginalPrice in upgrade/enroll confirmation modal fix: adhere to hideCourseOriginalPrice in upgrade/enroll confirmation modal Jul 15, 2024
Base automatically changed from ags/ent-9066-pt1 to master July 15, 2024 20:22
@adamstankiewicz adamstankiewicz marked this pull request as ready for review July 15, 2024 20:30
@adamstankiewicz adamstankiewicz merged commit 72c17d9 into master Jul 15, 2024
7 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-9066-pt3 branch July 15, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants