Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix auto-applied license flow #1119

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: fix auto-applied license flow #1119

merged 1 commit into from
Jul 17, 2024

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Jul 17, 2024

Fix the activateOrAutoApplySubscriptionLicense() function so that it doesn't early-return when there is no subscription license present (which is actually the expected case during the auto-apply flow), but does early return if there is no current subscription plan associated with the present customer agreement record.
ENT-9221

Local success (after fixing devstack CSRF_TRUSTED_ORIGINS in license-manager):
https://github.com/user-attachments/assets/5b4885b8-6ccf-4d4e-9aac-59df077d0df9

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Fix the `activateOrAutoApplySubscriptionLicense()` function
so that it doesn't early-return when there is no subscription
license present (which is actually the *expected* case during
the auto-apply flow), but *does* early return if there
is no current subscription plan associated with the present
customer agreement record.
ENT-9221
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (72c17d9) to head (d5fe284).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
+ Coverage   86.59%   86.79%   +0.20%     
==========================================
  Files         380      380              
  Lines        7916     7916              
  Branches     1937     1905      -32     
==========================================
+ Hits         6855     6871      +16     
+ Misses       1009      995      -14     
+ Partials       52       50       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveagent57 iloveagent57 merged commit e2a3310 into master Jul 17, 2024
7 checks passed
@iloveagent57 iloveagent57 deleted the aed/fix-auto-apply branch July 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants