Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove computed isCurrent property for subscription plans #1122

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

adamstankiewicz
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@adamstankiewicz adamstankiewicz changed the title fix: ensure isCurrent is available on subscriptionPlan after auto-applied license is activated fix: remove computed isCurrent property for subscription plans Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (dd43222) to head (1fda3f1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   86.79%   86.79%   -0.01%     
==========================================
  Files         380      380              
  Lines        7916     7913       -3     
  Branches     1943     1905      -38     
==========================================
- Hits         6871     6868       -3     
  Misses        995      995              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveagent57 iloveagent57 merged commit 3504133 into master Jul 18, 2024
7 checks passed
@iloveagent57 iloveagent57 deleted the ags/auto-applied-expired-subs branch July 18, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants