Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8962] fix: removed feature flag check from video detail page #1125

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Description
Removed the feature flag check from the video detail page, as it has already been applied on the video card that redirects to this page.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8962-feature-flag-fix branch from f6fe62d to 569f46d Compare July 22, 2024 08:10
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (d5ee30f) to head (569f46d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1125   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         388      388           
  Lines        8024     8024           
  Branches     1961     1960    -1     
=======================================
  Hits         6973     6973           
  Misses       1002     1002           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit 7620f17 into master Jul 22, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8962-feature-flag-fix branch July 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants