fix: use correct late redemption enablement key #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // redemption has been temporarily enabled by an operator for the policy. It will toggle | ||
| // itself back to False after a finite period of time. | ||
| policy.isLateRedemptionEnabled | ||
| policy.isLateRedemptionAllowed |
There was a problem hiding this comment.
😬 Oof, does this mean without this fix, the late enrollment feature might not have worked? Good catch!
pwnage101
force-pushed
the
pwnage101/ENT-9259-3
branch
from
19b8838
to
1b6e5f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 388 388
Lines 8069 8069
Branches 1983 1977 -6
=======================================
Hits 7023 7023
Misses 997 997
Partials 49 49 ☔ View full report in Codecov by Sentry. |
pwnage101
force-pushed
the
pwnage101/ENT-9259-3
branch
from
1b6e5f4
to
43f2f83
Compare
Renames: `isLateRedemptionEnabled` -> `isLateRedemptionAllowed` I can't quite fathom how this was wrong, but it's abundantly clear in the API serializer that the correct value should be `isLateRedemptionAllowed`. ENT-9259
pwnage101
force-pushed
the
pwnage101/ENT-9259-3
branch
from
43f2f83
to
5483853
Compare
adamstankiewicz
approved these changes
Jul 24, 2024
zwidekalanga
pushed a commit
to zwidekalanga/frontend-app-learner-portal-enterprise
that referenced
this pull request
Jul 30, 2024
Renames: `isLateRedemptionEnabled` -> `isLateRedemptionAllowed` I can't quite fathom how this was wrong, but it's abundantly clear in the API serializer that the correct value should be `isLateRedemptionAllowed`. ENT-9259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames:
isLateRedemptionEnabled->isLateRedemptionAllowedI can't quite fathom how this was wrong, but it's abundantly clear in the API serializer that the correct value should be
isLateRedemptionAllowed.ENT-9259