Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure transcript button appears in video player #1135

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jul 29, 2024

On stage/production (and seemingly locally on some machines), the "AD" transcripts button, added via vjstranscribe plugin for video.js, does not consistently appear, preventing users from using the transcript feature as expected.

This PR ensures the "AD" transcripts button always appears, using the out-of-the-box plugin by fetching the asynchronous transcripts data prior to initializing the player with videojs(...):

image

Video demo of fix

video-transcripts-locale-change.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@adamstankiewicz adamstankiewicz marked this pull request as draft July 29, 2024 18:44
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I have tested the changes on both the video detail page and course previews and everything is working fine. I think we're ready for a merge.

Thanks for contributing to the fix! 👍

@adamstankiewicz adamstankiewicz marked this pull request as ready for review July 30, 2024 13:40
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (5efbadd) to head (c490c0b).

Files Patch % Lines
src/components/video/VideoJS.jsx 55.00% 9 Missing ⚠️
src/components/video/data/hooks.js 91.66% 1 Missing and 1 partial ⚠️
src/components/video/data/service.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   87.12%   87.08%   -0.05%     
==========================================
  Files         391      392       +1     
  Lines        8123     8152      +29     
  Branches     2005     2011       +6     
==========================================
+ Hits         7077     7099      +22     
- Misses        997     1003       +6     
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit 7981e83 into master Jul 30, 2024
5 of 7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the ags/video-transcripts-fix branch July 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants