Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Detail Page Updates #1137

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

mahamakifdar19
Copy link
Contributor

Description

  • Temporarily hide skills section because the skills that we are currently retrieving for videos are inaccurate.
  • Turned off auto-play mode for videos.
  • Added some nits.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link
Contributor

@saleem-latif saleem-latif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, once that is addressed 👍🏼

src/components/microlearning/VideoDetailPage.jsx Outdated Show resolved Hide resolved
@mahamakifdar19 mahamakifdar19 force-pushed the maham/video_detail_page_nits branch 2 times, most recently from c905242 to 1eb9de9 Compare July 31, 2024 08:20
@mahamakifdar19 mahamakifdar19 marked this pull request as draft July 31, 2024 08:32
@mahamakifdar19 mahamakifdar19 marked this pull request as ready for review July 31, 2024 08:32
@bmtcril bmtcril closed this Jul 31, 2024
@bmtcril bmtcril reopened this Jul 31, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (7981e83) to head (ffbab77).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   87.08%   87.10%   +0.02%     
==========================================
  Files         392      392              
  Lines        8152     8167      +15     
  Branches     1977     2014      +37     
==========================================
+ Hits         7099     7114      +15     
  Misses       1003     1003              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit 4ea7549 into master Aug 1, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/video_detail_page_nits branch August 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants