Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove gating on learner credit enrollment upgrades from Dashboard #1139

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jul 31, 2024

ENT-9135

Removes the gating (i.e., staff user or feature flag enabled via query parameter) on the API call to can-redeem within potentially upgradeable audit course enrollments.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (70d9015) to head (4bf12da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   87.10%   87.09%   -0.01%     
==========================================
  Files         392      392              
  Lines        8165     8161       -4     
  Branches     2017     2009       -8     
==========================================
- Hits         7112     7108       -4     
  Misses       1003     1003              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit beeacc8 into master Aug 1, 2024
7 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-9135 branch August 1, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants