Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9376] Fix: Actively playing video restarts due to background query re-fetches #1174

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Sep 3, 2024

Ticket:
https://2u-internal.atlassian.net/browse/ENT-9376

Description
Made changes to ensure that the video player does not re-render / restart when @tanstack/react-query performs background re-fetches on queries rendered within the video detail page.

Screen Recording:
https://github.com/user-attachments/assets/77656631-bdbd-46a7-bec4-7ed1f50d8cc8

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 changed the title [ENT-9376] Fix: Actively playing video restarts due to component re-rendering during query background re-fetches [ENT-9376] Fix: Actively playing video restarts due to background query re-fetches Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (272f6dd) to head (6ab8467).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/components/video/VideoJS.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         394      394           
  Lines        8392     8392           
  Branches     2021     2021           
=======================================
  Hits         7403     7403           
  Misses        947      947           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9376 branch 7 times, most recently from b9cd465 to b088c13 Compare September 5, 2024 10:04
@mahamakifdar19 mahamakifdar19 reopened this Sep 5, 2024
@mahamakifdar19 mahamakifdar19 merged commit 334d87c into master Sep 6, 2024
5 of 6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9376 branch September 6, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants