Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure course about page acknowledges run-based assignments #1181

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Sep 12, 2024

Description

Ensures the course about page recognizes run-based assignments, displaying the Assigned badge and assignment-specific price strikeout messaging in the sidebar on the Course About page. This was supported by slightly refactoring to extend useIsCourseAssigned to utilize the util function determineAllocatedAssignmentsForCourse.

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (bd4087e) to head (27113ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         396      396           
  Lines        8404     8406    +2     
  Branches     2062     2064    +2     
=======================================
+ Hits         7426     7428    +2     
  Misses        935      935           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 0d978d2 into master Sep 12, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-8876-pt3 branch September 12, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants