Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add video_usage_key to video microlearning segment events #1191

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

macdiesel
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • [NA] Ensure English strings are marked for translation. See documentation for more details.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (22c26df) to head (d63306c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1191      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.02%     
==========================================
  Files         396      396              
  Lines        8392     8407      +15     
  Branches     2056     2022      -34     
==========================================
+ Hits         7419     7431      +12     
- Misses        931      934       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open question, non-blocking about the casing consistency of the segment events. LGTM otherwise 👍🏽

@macdiesel macdiesel merged commit 0eca5f7 into master Sep 17, 2024
5 of 6 checks passed
@macdiesel macdiesel deleted the bbeggs/instrumentation branch September 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants