fix: prevent NotFoundPage on successful redemption while still on ExternalCourseEnrollment
#1197
Conversation
| @@ -77,7 +77,7 @@ const ExternalCourseEnrollment = () => { | |||
| // current date is outside the enrollment window of the run. | |||
| if (userSubsidyApplicableToCourse.subsidyType === LEARNER_CREDIT_SUBSIDY_TYPE) { | |||
| const canRedeemDataCourseRun = redeemabilityPerContentKey.find(r => r.contentKey === courseRunKey); | |||
| if (!canRedeemDataCourseRun?.canRedeem) { | |||
| if (!canRedeemDataCourseRun?.canRedeem && !canRedeemDataCourseRun?.hasSuccessfulRedemption) { | |||
There was a problem hiding this comment.
Upon successful redemption of an Exec Ed course, the API calls to can-redeem, credits_available, and enterprise_course_enrollments are invalidated/re-fetched in parallel.
When the can-redeem API resolves first, it's response will update to have canRedeem: false and hasSuccessfulRedemption: true; however, this code path would handle this case as showing the <NotFoundPage /> component, which isn't correct.
Once the other API calls resolve, the user is navigated to the complete route for the enrollment confirmation screen as intended.
This fix ensures we don't show the <NotFoundPage /> while resolving the other API calls.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 396 396
Lines 8407 8407
Branches 2061 2022 -39
=======================================
Hits 7434 7434
- Misses 930 931 +1
+ Partials 43 42 -1 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
changed the title
adamstankiewicz
changed the title
NotFoundPage on successful redemption while still on ExternalCourseEnrollment
https://2u-internal.atlassian.net/browse/ENT-9423
For all changes
Only if submitting a visual change