Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure consistency around start dates on course run cards in Course page #1203

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

adamstankiewicz
Copy link
Member

Adds parity with start-based assignments by updating business logic around which start is displayed on the available course run cards in the Course page route.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (ac21d02) to head (18f724e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1203   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         398      398           
  Lines        8459     8459           
  Branches     2072     2073    +1     
=======================================
  Hits         7482     7482           
  Misses        934      934           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 3f6cf6d into master Oct 3, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/start-date-fix-coursepage branch October 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants