From 13a4e036c163407258b9ba01cf4043dbd94929d1 Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Wed, 21 Aug 2024 17:01:13 +0500
Subject: [PATCH 1/2] test: Add Node 20 to CI matrix
---
.github/workflows/node-ci.yml | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
index 69b5eaa7..c2ae932d 100644
--- a/.github/workflows/node-ci.yml
+++ b/.github/workflows/node-ci.yml
@@ -11,16 +11,18 @@ on:
jobs:
tests:
runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ node: [18, 20]
+ continue-on-error: ${{ matrix.node == 20 }}
steps:
- name: Checkout
uses: actions/checkout@v3
- - name: Setup Nodejs Env
- run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Nodejs
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
- node-version: ${{ env.NODE_VER }}
+ node-version: ${{ matrix.node }}
- name: Install dependencies
run: npm ci
From e0659fb33c80bae018313c79d1611a9b97af8f88 Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Wed, 21 Aug 2024 17:09:35 +0500
Subject: [PATCH 2/2] fix: updated failing snapshots
---
.../ProgramListPage.test.jsx.snap | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap b/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap
index ee9e73b9..fc21a4bb 100644
--- a/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap
+++ b/src/components/programs-list/tests/__snapshots__/ProgramListPage.test.jsx.snap
@@ -222,7 +222,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = `
>
@@ -251,7 +251,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = `
>
@@ -280,7 +280,7 @@ exports[`ProgramListPage correctly renders the loading page 1`] = `
>