Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 20 upgrade #298

Closed
5 tasks done
Tracked by #267
arbrandes opened this issue Mar 7, 2024 · 2 comments
Closed
5 tasks done
Tracked by #267

Node 20 upgrade #298

arbrandes opened this issue Mar 7, 2024 · 2 comments
Assignees
@BilalQamar95
Labels
maintenance Routine upkeep necessary for the health of the platform waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Comments

@arbrandes
Copy link
Contributor

arbrandes commented Mar 7, 2024 •
edited by brian-smith-tcril
Loading

Description

See the parent ticket for the general description and motivation, openedx/public-engineering#267. Make sure to follow its recommendations for each step of the process.

Tasks
Beta Give feedback
  1. chore: test against node 18 in CI #396
  2. feat: updated node to v20 #378
  3. test: Remove support for Node 18 #397
    waiting for eng review
    BilalQamar95
  4. Revert "test: Remove support for Node 18 (#397)" #420
  5. revert: revert: "test: Remove support for Node 18 (#397)" #436
@arbrandes arbrandes added the maintenance Routine upkeep necessary for the health of the platform label Mar 7, 2024
@feanil feanil mentioned this issue Jun 13, 2024
Closed
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 12, 2024
@justinhynes
Copy link
Contributor

It is my understanding that this upgrade will happen alongside other MFEs as part of openedx/public-engineering#267.

I'm not going to close this issue, but I'm not going to be tracking this as work Aperture needs to do as maintainers. I am assuming that there is a team/group of folks doing the updates as part of the public-engineering issue. (Please correct me if I'm wrong here!)

We are more than happy to verify and review the PR once the work is finished.

@justinhynes justinhynes removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 16, 2024
This was referenced Aug 22, 2024
Merged
Merged
@BilalQamar95 BilalQamar95 mentioned this issue Aug 23, 2024
Merged
@BilalQamar95 BilalQamar95 self-assigned this Aug 23, 2024
@deborahgu deborahgu added engineering review waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed engineering review labels Aug 30, 2024
@jsnwesson
Copy link
Contributor

The three tasks for updating Learner Record to Node 20 are complete! Closing this issue ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BilalQamar95 BilalQamar95

Labels
maintenance Routine upkeep necessary for the health of the platform waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Aperture-Maintained
Status: Done
Frontend Working Group
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@deborahgu @arbrandes @justinhynes @BilalQamar95 @jsnwesson @brian-smith-tcril