Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After resetting I can submit again without selecting a new option and it uses the previous submit value #1406

Closed
mariajgrimaldi opened this issue Jun 3, 2024 · 5 comments · May be fixed by openedx/edx-platform#35118
Closed

After resetting I can submit again without selecting a new option and it uses the previous submit value #1406

mariajgrimaldi opened this issue Jun 3, 2024 · 5 comments · May be fixed by openedx/edx-platform#35118
Labels
release testing Affects the upcoming release (attention needed)

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jun 3, 2024 •
edited
Loading

Expected behavior

The "Submit" button should be disabled after clicking reset option.

Actual behavior

After clicking the "Reset" button, questions are reset, but the "Submit" button stays active and clickable. If the user clicks the "Submit" button without selecting any option, it is marked incorrect.

Reset.Option.Issue.mov

Steps to reproduce

  1. Navigate to a common problem type component (SCQ, MCQ ) in the course.
  2. Attempt a question and submit an incorrect answer.
  3. Click the "Reset" button to reset the question.
  4. Click the submit button without selecting any option.
  5. Observe the behavior.

Additional information

  1. This issue affects all common problem components.

Original issue: openedx/wg-build-test-release#362
@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label Jun 3, 2024
@mariajgrimaldi
Copy link
Member Author

This is currently happening in quince as well.

@mariajgrimaldi
Copy link
Member Author

FYI @arbrandes @brian-smith-tcril @openedx/2u-infinity, please tag anyone you think can help. Thanks!

imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 10, 2024
@imasdekar
fix: disables the submit button on click of reset button
005be1b 
- whenever the reset button is clicked the submit button is disabled
except for cases when there is a gentle alert notification

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar imasdekar mentioned this issue Jul 10, 2024
Closed
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 14, 2024
@imasdekar
fix: disables the submit button on reset
ed2a679 
- disables the submit button on the click of reset button except for the
cases when there is a gentel alert notification.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 14, 2024
@imasdekar
fix: disables the submit button on reset
fd69b19 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 14, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
614ef63 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar imasdekar mentioned this issue Jul 14, 2024
Open
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 17, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
bf4fce0 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar
Copy link
Contributor

@mariajgrimaldi I have sent a merge request: openedx/edx-platform#35118 to fix this issue. Please take a look

imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 17, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
7deaedf 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 17, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
cd2e075 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 18, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
1f4e7e8 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Jul 31, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
b37ca7c 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
imasdekar added a commit to imasdekar/edx-platform that referenced this issue Aug 2, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
a7d9c3a 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Aug 23, 2024 •
edited
Loading

Hey @imasdekar, thank you so much for the fix! We really appreciate it. I'll look (or find someone who can) as soon as possible.

@mariajgrimaldi
Copy link
Member Author

This issue affects edx-platform instead of the MFE, so I'm going to close the issue in the MFE to track it in the BTR repo directly.

@mariajgrimaldi mariajgrimaldi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release testing Affects the upcoming release (attention needed)
Projects
Build-Test-Release Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly handles the enabling of submit button on reset imasdekar/edx-platform
2 participants
@imasdekar @mariajgrimaldi