-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Images sizes and src link, blockquote styles (master) #333
base: master
Are you sure you want to change the base?
feat: Images sizes and src link, blockquote styles (master) #333
Conversation
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
src/App.scss
Outdated
} | ||
|
||
& blockquote > p { | ||
border-left: 2px solid #ccc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Let's use the paragon color $gray-200
instead of hardcoded color #ccc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
aea6b79
to
c4a21e7
Compare
@vladislavkeblysh @ihor-romaniuk - just checking in on this! |
c4a21e7
to
6b301ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 1082 1086 +4
Branches 159 159
=========================================
+ Hits 1082 1086 +4 ☔ View full report in Codecov by Sentry. |
@mphilbrick211 I believe everything is ready for the final review and merging of this pull request into the quince branch. Could we proceed with that? |
Hi @ihor-romaniuk. This repo is currently in the process of getting a new maintainer. @arbrandes @brian-smith-tcril - is one of you able to take a look? |
One thing that feels like it's missing is what input data led to the screenshots in the initial post. @vladislavkeblysh - it would be wonderful if you could update the initial post to include that. Overall the code changes look good to me, I'd just like to play around with it in a sandbox to try to hit some edge cases before approving/merging. I've added the |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
Related Pull Requests