Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Header Customization via Frontend Plugin Framework #521

Open
brian-smith-tcril opened this issue Aug 9, 2024 · 8 comments
Open

Allow Header Customization via Frontend Plugin Framework #521

brian-smith-tcril opened this issue Aug 9, 2024 · 8 comments

Comments

@brian-smith-tcril
Copy link
Contributor

brian-smith-tcril commented Aug 9, 2024

It is important for site operators to be able to customize the Header. This is currently supported by having site operators fork this repository and npm install from their fork, however, that is a lot to ask of a site operator that just wants to make a few small changes.

Now that frontend-plugin-framework exists, we have an opportunity to make the header customization story a better one!

In this issue I would like to discuss:

  • What are the ways in which site operators want to customize the header?
    • What Plugin Slots can we create to support those use cases?
  • How can we help site operators that currently rely on the forking/npm install strategy move to using the frontend plugin framework plugin slot strategy?
    • One way to support this is to have a top-level plugin slot that wraps the entire header. What would the requirements for that top-level plugin slot be?
  • What aspects of the current technical architecture of this repository will make this difficult?
    • How do we handle the current LearningHeader vs StudioHeader vs DesktopHeader vs MobileHeader situation? Is there a clear path forward for consolidating those? Is consolidating those required to provide a good site operator experience for using plugin slots?
  • Anything and everything else people can think of that will impact how the header plugin slots are created!
@brian-smith-tcril
Copy link
Contributor Author

How can we help site operators that currently rely on the forking/npm install strategy move to using the frontend plugin framework plugin slot strategy?

I'd like to clarify here that we still need to support the current forking/npm install customization strategy - but it is not a strategy we want to recommend.

This will likely impact how we need to think about

How do we handle the current LearningHeader vs StudioHeader vs DesktopHeader vs MobileHeader situation?

@adamstankiewicz
Copy link
Member

Anything and everything else people can think of that will impact how the header plugin slots are created!

There might still be an opportunity for frontend-component-header to rely on Navbar from Paragon (docs). There's has been early discussion/design work in the past within Paragon Working Group (#wg-paragon) about how to make the Paragon Navbar component more generic, with defined slots / permutations, such that it can be used within the platform (e.g., via frontend-component-header). The interaction with Navbar from Paragon might be out-of-scope for this particular bit, but I still feel this is still a direction possibly worth pursuing.

@brian-smith-tcril
Copy link
Contributor Author

How do we handle the current LearningHeader vs StudioHeader vs DesktopHeader vs MobileHeader situation?

I think noting how headers are being used in the default enabled MFEs in tutor are using will be helpful for figuring this out:

Overview (Table)

MFE Header
Authn None
Account Header
Communications LearningHeader
Course Authoring StudioHeader
Discussions LearningHeader
Gradebook Header
Learner Dashboard Header
Learning LearningHeader
ORA Grading LearningHeader
Profile Header

Details

Authn

No header

Account

Import

import Header from '@edx/frontend-component-header';

Use

<Header />

Communications

Import

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use

<Header
  className="learning-header"
  courseOrg={courseMetadata.org}
  courseNumber={courseMetadata.number}
  courseTitle={courseMetadata.title}
/>

Course Authoring

Import

import { StudioHeader } from '@edx/frontend-component-header';

Use

<StudioHeader
  org={org}
  number={number}
  title={title}
  isHiddenMainMenu={isHiddenMainMenu}
  mainMenuDropdowns={mainMenuDropdowns}
  outlineLink={outlineLink}
  searchButtonAction={meiliSearchEnabled ? openSearchModal : undefined}
/>

Discussions

Import

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use

{!enableInContextSidebar && (<Header courseOrg={org} courseNumber={courseNumber} courseTitle={courseTitle} />)}

Gradebook

Import

import Header from '@edx/frontend-component-header';

Use

<Header />

Learner Dashboard

Import

import Header from '@edx/frontend-component-header';

Use

<Header
  mainMenuItems={learnerHomeHeaderMenu.mainMenu}
  secondaryMenuItems={learnerHomeHeaderMenu.secondaryMenu}
  userMenuItems={learnerHomeHeaderMenu.userMenu}
/>

Learning

Import (CourseAccessErrorPage)

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use (CourseAccessErrorPage)

<Header />

Import (TabPage)

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use (TabPage)

<Header courseOrg={org} courseNumber={number} courseTitle={title} />

Import (GoalUnsubscribe)

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use (GoalUnsubscribe)

<Header showUserDropdown={false} />

ORA Grading

Import

import { LearningHeader as Header } from '@edx/frontend-component-header';

Use

<Header
  courseTitle={courseMetadata.title}
  courseNumber={courseMetadata.number}
  courseOrg={courseMetadata.org}
  data-testid="header"
/>

Profile

Import

import Header from '@edx/frontend-component-header';

Use

<Header />

@brian-smith-tcril
Copy link
Contributor Author

brian-smith-tcril commented Aug 12, 2024

Adding screenshots to aid in visual discussions

Authn

No header

Account

Screenshot from 2024-08-12 11-23-24
image
image

Communications

image
image

Course Authoring

image
image
image
image
image
image

Discussions

image
image

Gradebook

image
image
image

Learner Dashboard

Important

These screenshots are from before openedx/frontend-app-learner-dashboard#327 landed

image
image
image

Learning

CourseAccessErrorPage

// todo

TabPage

image
image
image
image

GoalUnsubscribe

// todo

ORA Grading

image
image

Profile

image
image
image

@michaelwheeler
Copy link

What are the ways in which site operators want to customize the header?

It would be really great to simply be able to add/remove/modify links in the main navigation and user menus without having to maintain an entire header component.

@brian-smith-tcril
Copy link
Contributor Author

@asadali145 I'd love to hear your thoughts on this! In openedx/platform-roadmap#349 you noted wanting to be able to customize the URLs for the links in the user dropdown menu - are there any other header customizations you were hoping to be able to do without forking?

@jmakowski1123
Copy link

Product Requirements defined here - please provide input in the wiki! https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4412243977/Proposal+Customizable+Header+for+LMS

@asadali145
Copy link

asadali145 commented Aug 16, 2024

Hi @brian-smith-tcril, We are using a few customization options already provided by the header and have forked the header to add a few more customizations. Here is the complete list:

  • Full name in place of username
  • Customized labels and URLs in the user dropdown.
  • Custom Help button link.
  • Extra links in the left header menu.
  • Custom logo

This issue sums up things nicely and identifies all our pain points.

@jmakowski1123 has added all of the customizations that we look for in the proposal. I have left a comment with a couple more suggestions.

CC: @pdpinch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Being Developed
Development

No branches or pull requests

5 participants