-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Django 4.2 #518
Conversation
Thanks for the pull request, @raymond1242! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
95b796e
to
29ee8eb
Compare
Hi @raymond1242! Just flagging that there's a failing check. |
Hi Michelle. I realized the mistake, and will fix it ASAP
…On Fri, Sep 15, 2023 at 8:53 AM Michelle Philbrick ***@***.***> wrote:
Hi @raymond1242 <https://github.com/raymond1242>! Just flagging that
there's a failing check.
—
Reply to this email directly, view it on GitHub
<#518 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BEJPWZSBEWO6EFOQKLCTX2RMWZANCNFSM6AAAAAA4PPEZ2E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
a623438
to
64c37c5
Compare
Hi @mphilbrick211! I fixed the error, could you please approve the workflows |
bb025f5
to
4f1e1bd
Compare
4f1e1bd
to
c8419f4
Compare
Hi @mphilbrick211, I have already completed all the steps of the issue and all tests were green, due to main branch updating conflict I had to rebase the branch to solve conflicts and it sends another approval check, that's the reason tests are yellow now. I'm waiting for your approval and review 🙌🏻. |
Thanks @raymond1242! I will look into getting tests run for you. |
c8419f4
to
51a5d39
Compare
@raymond1242 looks like there are some failures. Can you have a look? It's possible some code related to your changes changed out from under you. |
Hi @raymond1242! Just following up on this :) |
Hi @raymond1242 - just checking in to see if you plan on pursuing this pull request? CC: @openedx/build-test-release-wg-security-patchers - just in case someone can push this through if needed. |
Hi @mphilbrick211, I'm going to remove this PR |
@raymond1242 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Django 4.2 Upgrade
Testing considerations
already been performed.
Post-review
Squash commits into discrete sets of changes