feat: Add db index to License.status field #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-8271
branch
from
86eeed7
to
8b03faa
Compare
|
Yep, that's right, the only time we list/retrieve all licenses is within the context of a single subscription plan. I didn't know a composite indexes were a thing, I'll look into them. |
pwnage101
force-pushed
the
pwnage101/ENT-8271
branch
from
8b03faa
to
1b86cee
Compare
iloveagent57
approved these changes
Jan 29, 2024
This field is used by the license REST APIs for sorting and filtering, as well as all endpoints which contain license counts by status, which makes it a good candidate for being indexed. ENT-8271
pwnage101
force-pushed
the
pwnage101/ENT-8271
branch
from
1b86cee
to
f248153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is used by the license REST APIs for sorting and filtering, as well as all endpoints which contain license counts by status, which makes it a good candidate for being indexed.
ENT-8271