Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify License Revocation Endpoint Behavior #698

Merged

Conversation

hamzawaleed01
Copy link
Member

@hamzawaleed01 hamzawaleed01 commented Aug 20, 2024

Description

Description of changes made

Link to the associated ticket: https://2u-internal.atlassian.net/browse/ENT-9206

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch from 392ece9 to 0d3c19d Compare August 23, 2024 12:56
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch from 57e2038 to dfe74aa Compare September 3, 2024 10:46
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch 4 times, most recently from 212e667 to 91c7ef5 Compare September 9, 2024 11:05
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch from 91c7ef5 to d249767 Compare September 9, 2024 11:18
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions but looks good to merge.

license_manager/apps/api/v1/views.py Outdated Show resolved Hide resolved
license_manager/apps/api/v1/views.py Outdated Show resolved Hide resolved
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch 3 times, most recently from 520f6c3 to 455ab8a Compare September 10, 2024 07:26
…9206/modify-license-mgr-bulk-revoke-behaviour
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch from 455ab8a to 9271086 Compare September 10, 2024 09:24
@hamzawaleed01 hamzawaleed01 merged commit 99289ff into master Sep 10, 2024
5 checks passed
@hamzawaleed01 hamzawaleed01 deleted the ENT-9206/modify-license-mgr-bulk-revoke-behaviour branch September 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants