Fix/memory leak #268
Closed
Fix/memory leak #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* october bugfixes Change some icons to help adjust color themes (DeleteAccountView, Send button on the keyboard, etc.) Fix CSSInjector style by adding 100% width. Need for normal work at Handouts view. Add new logic for icons viewing in CourseVerticalView. Fix a bug where the discussion page does not appear in case there is only one on the page. Fix a bug with text trimming on ParentCommentView. Change button design on PostsView by Design code. Fix the issue with the English localization on DeleteAccountView. Fix error handling at DeleteAccountViewModel. * update xcode version for unit tests * Downgrade xcode version for unit tests * Update unit_tests.yml * Update Fastfile * Update unit_tests.yml * code style improvements
* Transcript navigation Display of video transcripts with active sentence highlighting. Tapping on transcript sentences to navigate to the corresponding part of the video. Mechanism to quickly return to the current active sentence after scrolling. https://github.com/openedx/openedx-app-ios/assets/128456094/b2cf1f49-e23b-42dd-a9b0-0ddac26bda59
* add Discussion Profile View * add tests * return the old preview for tests fixing * Update ProfileRepository.swift
* Add landscape mode support * remove commented lines * Update CourseUnitView.swift Add one dot to progress * update design * resolve merge conflicts * update progress dots * bug fixes When a user swipes back from the problem screen, the app numbs and the user cannot tap. Fixed. The component name is in the center of the screen. Fixed. * code style improvements --------- Co-authored-by: stepanokdev <[email protected]>
The type of access token can be changed in the Core.Config class.
* Add whats new screen * add whats new logic after user login * code style fixes add accessibility support add feature flag to Config * Add tests * change the done button icon and add the fade-in animation to the previous button * Update Config.swift change whatsNewEnabled to false * fix mock files * add test file to project
* feat: course dates * add tests to course dates * cleanup * add analytics and translation * regenerate CourseMock for analytics * chore: add translations * chore: update .gitignore and remove files * fix: remove gitignored file * fix: update .gitignore * fix: another try on removing files
* add update version notifications * App update version views * fix logout logic * update tests * Update UpdateRequiredView.swift * remove debug prints * switch the localization to default * minor fixes after review * add executable to RequestInterceptor * code style review * add prefetchDataForOffline to MainScreenViewModel * remove appUpdateFeatureEnabled flag * disable version button when is up to date * fix merge conflicts --------- Co-authored-by: stepanokdev <[email protected]>
* enable AirPlay screencasting * fix the bug where screencast continues to stream the video even if the user clicks next * remove commented code
* add HLS quality support * update default localization * Update VideoPlayerViewModelTests.swift * change 360 quality localizations * fix resolution changing logic * rename the getVideoResolution function
Co-authored-by: stepanokdev <[email protected]>
* chore: update view top margin, handle case for today dat with the blocks, refactoring * chore: address feedback, disable block if content is verified only * refactor: remove unused import
Co-authored-by: stepanokdev <[email protected]>
* add AppReviewView * add viewmodel * work in progress * Add third party mail clients support * In-App Review system * add localizations * Update Assets.swift * bug fixes [header] the system bar disappears if a user used the rate us pop-up [rate_us] the user isn't able to submit a feedback in the landscape mode [email_feedback] the email template formatting must have a user/device info [email_agent] iOS agent displays bit a user cannot use it (the icon isn't clickable) * Update AppReview logic Added a check to ensure that the rating window is displayed no more than once every 4 months. Corrected copyright in ThirdPartyMailer * fixes move requestReview logic to AppReviewView replace if/else logic to switch in AppReviewViewModel * Fix merge conflicts push SKStoreReviewController logic to extension for iOS 15 compatibility --------- Co-authored-by: stepanokdev <[email protected]>
* feat: add config to process config * chore: handle configuration provided as argument, handle firebase crashlytics google app id, remove process_config.sh in favour of build script * chore: update implementation to provide config mappings based on Xcode scheme and a default config * chore: update config test cases * chore: make pass dictionary to features config * chore: update process_config.py and releated files * chore: add documentation fix: fix documentation link fix: fix documentation link fix: remove type fix: remove type fix: cleanup * fix: add default config_settings.yaml * chore: address feedback * chore: update config initialization * chore: address feedback * chore: address feedback
* add accessibility support * ios 17 fixes * add voiceover to download states on CourseVertical and CourseOutline views * Update CourseCellView.swift --------- Co-authored-by: stepanokdev <[email protected]>
* Update ci_prepare_env.sh
* chore: add microsoft and google scheme to info.plist * fix: fix config tests file reference
* fix: add support for login via username * chore: fix typo in test case * chore: add check to validate if username is not empty * chore: address feedback * chore: add check for white space on email * chore: handle white spaces in username validation * chore: address feedback * fix: remove unused translation * Revert "fix: remove unused translation" This reverts commit 4c5120c.
* feat: pre-login mobile app exploration * fix: generated mock files again to fix the broken tests * refactor: file formatting * fix: fix broken code after GitHub resolve conflicts * chore: making feature configureable via config * refactor: remove empty method that was wrote for implementing analytics in future * fix: fixup after rebasing with develop * refactor: address feedback * refactor: address review feedback * fix: getting the ci_script changes * refactor: address review feedback * refactor: delete old config file
…x#182) * feat: openedX app theming capability improvements * fix: mixup after rebasing with develop * refactor: code refactor * chore: Apply accentColor to tabbar items for theme configureable * fix: fixup after merging the develop branch * feat: openedX app theming capability improvements * chore: remove configureable assets and font parser from Core * chore: address review feedback(linked the Theme framework with Core framework) * fix: fix broken code after conflicts resolve * fix: fix the broken archive process * refactor: remove unused old Environment file
…ook, and Google (openedx#176) * feat: add login with * chore: remove spacing * fix: padding bottom social view * chore: result social * chore: add new struct for credentials * chore: add request social login * chore: add request and change design buttons * chore: add handle MSAL Response * chore: add ocial login enabled feature flag * chore: add configs and flags * chore: rename file * chore: add accessibility, localizable strings uk, and flags for socials * chore: remove extra code * chore: add google config * chore: move enabled google sign in to google config * chore: add new dict social login * chore: remove extra code, change names, add colors * refactor: open URL options key method * refactor: add SocialSignView previews * chore: add apple sign in config, pr issues * chore: improvement sign up with third party auth, new error if third party auth cancelled * chore: add not linked acc error when login by third party auth * chore: add same canceled error * chore: add error if not register by social auth * fix: fix msal lib * chore: login if can when register if social provider and add name email to field after apple sign in * chore: save full name after login with apple * chore: add microsoft to package * chore: changes from PR feedback * chore: changes from PR feedback * chore: add tests * chore: changes from PR feedback * chore: remove extra code * chore: remove extra code and add tests * chore: changes for saving apple info to appstorage * chore: remove extra code and change social auth details * chore: change LoginMethod -> AuthMethod and remove extra code * chore: change names --------- Co-authored-by: Eugene Yatsenko <[email protected]>
* feat: added unit popup menu * chore: a little design changes * feat: added accessibilty * fix: accessiblity fix * chore: remove config paramaters * fix: added flag to hide/show unit dropdown menu * fix: title for video type block * chore: refactor * feat: added feature flag * chore: PR review fixes * fix: merge conflict
* fix: crash when navigate to next vertical * chore: refactor * chore: swiftlint warnings * chore: swiftlint warnings
* feat: navigate to course component from course dates tab * chore: renamed methods and used already fetched course data for course hyperlinks * refactor: address review feedback
…ifiers Chore: Set Accessibility Identifiers for Startup, Signin. Register, WhatsNew Screens
Add custom user agent to hide app banner on web page
Replace WhatsNew file with Script
# Conflicts: # Course/Course.xcodeproj/project.pbxproj # Course/Course/Data/CourseRepository.swift
|
wrong target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding to bug [iOS] Video continues to play when another video starts #244