Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Custom Elasticsearch Host #49

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Nov 20, 2023

This will introduce:

  • New config: K8S_HARMONY_ELASTIC_HOST to have custom hosts.
  • Makefile: to follow other tutor plugins.
  • Support for python 3.11 and 3.12 added.
  • fixed tutor version to Palm release, so older versions (without multi tenant and other features can't install it)
  • Updated document (markdown issues was cleaned up and tutor-mfe on k8s removed)
  • Some cleanup with isort and black.

I guess we should mention in the documents that multi-tenant works on palm+

@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2023
@CodeWithEmad CodeWithEmad force-pushed the fix/custom-elastic-host branch 2 times, most recently from cdbfac6 to b4958fc Compare November 20, 2023 08:19
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Nov 20, 2023
@e0d
Copy link

e0d commented Nov 20, 2023

@CodeWithEmad
I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Nov 20, 2023
@CodeWithEmad
Copy link
Member Author

CodeWithEmad commented Nov 20, 2023

Sure. Thanks for the reminder 🙂

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Nov 20, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 23, 2023

Hey @CodeWithEmad, thank you for this contribution! The build is green so we should be good to move forward with engineering review.

@gabor-boros When you get a minute, could you post an update about when you'd be able to review this PR?

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 23, 2023
@gabor-boros
Copy link
Contributor

@itsjeyd I just allowed the workflow pipelines to run, but I had no intention to review the PR. If there is a need for a reviewer, I can take the review tho.

@gabor-boros gabor-boros self-requested a review November 28, 2023 17:15
@gabor-boros
Copy link
Contributor

FTR: Set myself as a reviewer.

@itsjeyd
Copy link

itsjeyd commented Nov 29, 2023

Thanks for taking the review @gabor-boros! For next time, are there other people with merge rights to this repo that I could have pinged?

@gabor-boros
Copy link
Contributor

I guess MoisesGSalas, jfavellar90, bradenmacdonald, felipemontoya, cmltaWt0 all have merge rights though I didn't confirm

Copy link
Contributor

@gabor-boros gabor-boros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeWithEmad Thank you for the PR! I left a minor comment which is rather a question.

I agree with your comment that the Palm+ requirement for the shared ES cluster should be mentioned in the docs. Although it is not strictly related to this PR, would you like/have time to add that not to the docs in the scope of this PR? If not, we can create a separate PR for that.

tutor-contrib-harmony-plugin/setup.py Outdated Show resolved Hide resolved
with this, we can use different elastic hosts in the plugin
Mark down warnings were fixed in README.md
isort and black were used in python files
this was added to make sure all tutor plugins use the same pattern and file structure.
from olive version, this was fixed and was removed from documentation
Multi-tenant Elasticsearch prerequisites are not available till palm version
Copy link
Contributor

@gabor-boros gabor-boros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 Thank you for the changes again, @CodeWithEmad. The changes are approved and I'm going to merge them in a bit.

@gabor-boros gabor-boros merged commit 87229e5 into openedx:main Dec 11, 2023
2 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the fix/custom-elastic-host branch December 11, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants